misc fixes for create and list

Rex-Virtualization-CBSD/MANIFEST

@@ -1,6 +1,7 @@
 Changes
 lib/Rex/Virtualization/CBSD.pm
 lib/Rex/Virtualization/CBSD/cbsd_base_dir.pm
+lib/Rex/Virtualization/CBSD/create.pm
 lib/Rex/Virtualization/CBSD/disk_list.pm
 lib/Rex/Virtualization/CBSD/freejname.pm
 lib/Rex/Virtualization/CBSD/info.pm
@@ -20,6 +21,22 @@ Makefile.PL
 MANIFEST			This list of files
 README
 t/00-load.t
+t/01-load.t
+t/02-load.t
+t/03-load.t
+t/04-load.t
+t/05-load.t
+t/06-load.t
+t/07-load.t
+t/08-load.t
+t/09-load.t
+t/10-load.t
+t/11-load.t
+t/12-load.t
+t/13-load.t
+t/14-load.t
+t/15-load.t
+t/16-load.t
 t/manifest.t
 t/pod-coverage.t
 t/pod.t

Rex-Virtualization-CBSD/lib/Rex/Virtualization/CBSD.pm

@@ -25,7 +25,13 @@ our $VERSION = '0.0.1';
 
     set virtualization => "CBSD";
     
-    use Data::Dumper;
+
+    print Dumper vm 'create', name=>'foo',
+                              'vm_os_type'=>'freebsd',
+                              'vm_os_profile'=>'FreeBSD-x64-13.0',
+                              'vm_ram'=>'1g',
+                              'vm_cpus'=>'1',
+                              'imgsize'=>'10g';
 
 =cut
 
@@ -207,7 +213,7 @@ The returned array is a hash of hashes. The first level hash is the jname.
 
     nodename - The node name that this is set to run on.
     
-    vm - Name of the VM.
+    name - Name of the VM.
     
     jid - Jail ID/process ID of the VM if running. IF '0' it is not running.
     

Rex-Virtualization-CBSD/lib/Rex/Virtualization/CBSD/create.pm

@@ -57,13 +57,13 @@ sub execute {
 
 		if ( defined( $opts{$key} ) ) {
 
-			# make sure it does not contain any tabs, spaces, =, \. /, ', ", or new lines.
-			if ( $opts{$key} =~ /[\t\ \=\\\/\'\"\n]/ ) {
+			# make sure it does not contain any tabs, single/double quotes, and new lines
+			if ( $opts{$key} =~ /[\t\'\"\n]/ ) {
 				die 'The value "'
 					. $opts{$key}
 					. '" for key "'
 					. $key
-					. '" matched /[\t\ \=\/\\\'\"\n]/, meaning it is not a valid value';
+					. '" matched /[\t\'\"\n]/, meaning it is not a valid value';
 			}
 
 			if ( defined( $opts{$key} ) ) {

Rex-Virtualization-CBSD/lib/Rex/Virtualization/CBSD/list.pm

@@ -45,13 +45,13 @@ sub execute {
 
 		# needs to be updated if display= is ever changed
 		(
-			$VM{'node'}, $VM{'vm'}, $VM{'pid'}, $VM{'ram'},    $VM{'curmem'}, $VM{'cpus'},
+			$VM{'node'}, $VM{'name'}, $VM{'pid'}, $VM{'ram'},    $VM{'curmem'}, $VM{'cpus'},
 			$VM{'pcpu'}, $VM{'os'}, $VM{'ip4'}, $VM{'status'}, $VM{'vnc'},    $VM{'path'}
 		) = split( /[\ \t]+/, $line );
 		$VMs{ $VM{'name'} } = \%VM;
 	}
 
-	return \%VMs;
+	return %VMs;
 }
 
 1;

Rex-Virtualization-CBSD/t/01-load.t

@@ -7,7 +7,7 @@ use Test::More;
 plan tests => 1;
 
 BEGIN {
-    use_ok( 'Rex::Virtualization::CBSD::list' ) || print "Bail out!\n";
+    use_ok( 'Rex::Virtualization::CBSD::cbsd_base_dir' ) || print "Bail out!\n";
 }
 
-diag( "Testing Rex::Virtualization::CBSD::list $Rex::Virtualization::CBSD::list::VERSION, Perl $], $^X" );
+diag( "Testing Rex::Virtualization::CBSD::cbsd_base_dir $Rex::Virtualization::CBSD::cbsd_base_dir::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/02-load.t

@@ -7,7 +7,7 @@ use Test::More;
 plan tests => 1;
 
 BEGIN {
-    use_ok( 'Rex::Virtualization::CBSD::remove' ) || print "Bail out!\n";
+    use_ok( 'Rex::Virtualization::CBSD::create' ) || print "Bail out!\n";
 }
 
-diag( "Testing Rex::Virtualization::CBSD::remove $Rex::Virtualization::CBSD::remove::VERSION, Perl $], $^X" );
+diag( "Testing Rex::Virtualization::CBSD::create $Rex::Virtualization::CBSD::create::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/03-load.t

@@ -7,7 +7,7 @@ use Test::More;
 plan tests => 1;
 
 BEGIN {
-    use_ok( 'Rex::Virtualization::CBSD::start' ) || print "Bail out!\n";
+    use_ok( 'Rex::Virtualization::CBSD::freejname' ) || print "Bail out!\n";
 }
 
-diag( "Testing Rex::Virtualization::CBSD::start $Rex::Virtualization::CBSD::start::VERSION, Perl $], $^X" );
+diag( "Testing Rex::Virtualization::CBSD::freejname $Rex::Virtualization::CBSD::freejname::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/04-load.t

@@ -7,7 +7,7 @@ use Test::More;
 plan tests => 1;
 
 BEGIN {
-    use_ok( 'Rex::Virtualization::CBSD::stop' ) || print "Bail out!\n";
+    use_ok( 'Rex::Virtualization::CBSD::info' ) || print "Bail out!\n";
 }
 
-diag( "Testing Rex::Virtualization::CBSD::stop $Rex::Virtualization::CBSD::stop::VERSION, Perl $], $^X" );
+diag( "Testing Rex::Virtualization::CBSD::info $Rex::Virtualization::CBSD::info::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/05-load.t

@@ -7,7 +7,7 @@ use Test::More;
 plan tests => 1;
 
 BEGIN {
-    use_ok( 'Rex::Virtualization::CBSD::disk_list' ) || print "Bail out!\n";
+    use_ok( 'Rex::Virtualization::CBSD::list' ) || print "Bail out!\n";
 }
 
-diag( "Testing Rex::Virtualization::CBSD::disk_list $Rex::Virtualization::CBSD::disk_list::VERSION, Perl $], $^X" );
+diag( "Testing Rex::Virtualization::CBSD::list $Rex::Virtualization::CBSD::list::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/06-load.t

@@ -7,7 +7,7 @@ use Test::More;
 plan tests => 1;
 
 BEGIN {
-    use_ok( 'Rex::Virtualization::CBSD::restart' ) || print "Bail out!\n";
+    use_ok( 'Rex::Virtualization::CBSD::nic_list' ) || print "Bail out!\n";
 }
 
-diag( "Testing Rex::Virtualization::CBSD::restart $Rex::Virtualization::CBSD::restart::VERSION, Perl $], $^X" );
+diag( "Testing Rex::Virtualization::CBSD::nic_list $Rex::Virtualization::CBSD::nic_list::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/07-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::pause' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::pause $Rex::Virtualization::CBSD::pause::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/08-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::pci_list' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::pci_list $Rex::Virtualization::CBSD::pci_list::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/09-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::remove' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::remove $Rex::Virtualization::CBSD::remove::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/10-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::restart' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::restart $Rex::Virtualization::CBSD::restart::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/11-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::set' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::set $Rex::Virtualization::CBSD::set::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/12-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::start' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::start $Rex::Virtualization::CBSD::start::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/13-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::stop' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::stop $Rex::Virtualization::CBSD::stop::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/14-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::vm_os_profiles' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::vm_os_profiles $Rex::Virtualization::CBSD::vm_os_profiles::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/15-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::vm_os_profiles_hash' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::vm_os_profiles_hash $Rex::Virtualization::CBSD::vm_os_profiles_hash::VERSION, Perl $], $^X" );

Rex-Virtualization-CBSD/t/16-load.t

@@ -0,0 +1,13 @@
+#!perl
+use 5.006;
+use strict;
+use warnings;
+use Test::More;
+
+plan tests => 1;
+
+BEGIN {
+    use_ok( 'Rex::Virtualization::CBSD::vm_os_types' ) || print "Bail out!\n";
+}
+
+diag( "Testing Rex::Virtualization::CBSD::vm_os_types $Rex::Virtualization::CBSD::vm_os_types::VERSION, Perl $], $^X" );